From: Amos Jeffries <squid3@treenet.co.nz>
Date: Thu, 10 Jul 2008 13:22:19 +0000 (+1200)
Subject: Author: Christos Tsantilas <chtsanti@users.sourceforge.net>
X-Git-Tag: SQUID_3_0_STABLE8~14
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=2a4b3aa8a2d20e4e553b5179902b9965c8c551a0;p=thirdparty%2Fsquid.git

Author: Christos Tsantilas <chtsanti@users.sourceforge.net>
Bug 2400: ICAP accept mechanism assumes okay result

ACL checks produces an ACCESS_REQ_PROXY_AUTH result but ICAP
result handler assumes any non-zero result means ACCESS_ALLOWED

This can result in many requests being shunted to ICAP incorrently.
---

diff --git a/src/ICAP/ICAPConfig.cc b/src/ICAP/ICAPConfig.cc
index 4bb699a658..378e461b26 100644
--- a/src/ICAP/ICAPConfig.cc
+++ b/src/ICAP/ICAPConfig.cc
@@ -218,7 +218,7 @@ ICAPAccessCheck::ICAPAccessCheckCallbackWrapper(int answer, void *data)
         debugs(93, 5, "ICAPAccessCheckCallbackWrapper matchedClass = " << ac->matchedClass.buf());
     }
 
-    if (!answer) {
+    if (answer!=ACCESS_ALLOWED) {
         ac->checkCandidates();
         return;
     }