From: Victor Julien <victor@inliniac.net>
Date: Fri, 11 Mar 2016 06:01:06 +0000 (+0100)
Subject: ioctl: fix NULL check after dereference (CID 1204326)
X-Git-Tag: suricata-3.0.1RC1~33
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=2a7f06843814d3216e4f623c58e80ef4d19638c6;p=thirdparty%2Fsuricata.git

ioctl: fix NULL check after dereference (CID 1204326)
---

diff --git a/src/util-ioctl.c b/src/util-ioctl.c
index 99a84a7e62..e0b5ef824b 100644
--- a/src/util-ioctl.c
+++ b/src/util-ioctl.c
@@ -117,18 +117,16 @@ int GetIfaceMTU(const char *pcap_dev)
  */
 int GetIfaceMaxPacketSize(const char *pcap_dev)
 {
-    int ll_header = GetIfaceMaxHWHeaderLength(pcap_dev);
-    int mtu = 0;
-
     if ((pcap_dev == NULL) || strlen(pcap_dev) == 0)
         return 0;
 
-    mtu = GetIfaceMTU(pcap_dev);
+    int mtu = GetIfaceMTU(pcap_dev);
     switch (mtu) {
         case 0:
         case -1:
             return 0;
     }
+    int ll_header = GetIfaceMaxHWHeaderLength(pcap_dev);
     if (ll_header == -1) {
         /* be conservative, choose a big one */
         ll_header = 16;