From: Timo Sirainen <timo.sirainen@dovecot.fi>
Date: Mon, 14 Dec 2015 15:42:34 +0000 (+0200)
Subject: lib: Avoid passing NULL to qsort() or bsearch() on empty array.
X-Git-Tag: 2.2.22.rc1~407
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=2a8253ebc3daefcc9862794b167f2136fb287788;p=thirdparty%2Fdovecot%2Fcore.git

lib: Avoid passing NULL to qsort() or bsearch() on empty array.

This wouldn't normally matter because count=0 so it wouldn't be dereferenced
anyway. But it triggered a run-time warning from clang, so lets fix it.
---

diff --git a/src/lib/array.c b/src/lib/array.c
index acc3853299..619d43cb6b 100644
--- a/src/lib/array.c
+++ b/src/lib/array.c
@@ -124,6 +124,8 @@ void array_sort_i(struct array *array, int (*cmp)(const void *, const void *))
 	unsigned int count;
 
 	count = array_count_i(array);
+	if (count == 0)
+		return;
 	qsort(buffer_get_modifiable_data(array->buffer, NULL),
 	      count, array->element_size, cmp);
 }