From: Volker Lendecke Date: Tue, 2 Apr 2019 14:37:39 +0000 (+0200) Subject: rpc: Don't crash if npa_accept fails X-Git-Tag: tdb-1.4.1~537 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=2a926231ab9582a4e0cc778032f2c8575f754a9e;p=thirdparty%2Fsamba.git rpc: Don't crash if npa_accept fails We can only rely on session_info_transport to be filled correctly upon success of the accept_existing_recv function Signed-off-by: Volker Lendecke Reviewed-by: Jeremy Allison --- diff --git a/source3/rpc_server/rpc_server.c b/source3/rpc_server/rpc_server.c index 0230d73abb2..f0870c88174 100644 --- a/source3/rpc_server/rpc_server.c +++ b/source3/rpc_server/rpc_server.c @@ -357,8 +357,6 @@ static void named_pipe_accept_done(struct tevent_req *subreq) &npc->local_server_name, &session_info_transport); - npc->session_info = talloc_move(npc, &session_info_transport->session_info); - TALLOC_FREE(subreq); if (ret != 0) { DEBUG(2, ("Failed to accept named pipe connection! (%s)\n", @@ -367,6 +365,9 @@ static void named_pipe_accept_done(struct tevent_req *subreq) return; } + npc->session_info = talloc_move( + npc, &session_info_transport->session_info); + ret = make_server_pipes_struct(npc, npc->msg_ctx, npc->pipe_name, NCACN_NP,