From: Björn Baumbach <bb@sernet.de>
Date: Wed, 18 Dec 2019 16:15:13 +0000 (+0100)
Subject: python/samdb: fetch specific error if there are more than one search results
X-Git-Tag: samba-4.12.0rc1~16
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=2abebee1405d2c7606e3980cfc07fec101c24297;p=thirdparty%2Fsamba.git

python/samdb: fetch specific error if there are more than one search results

There can be more than one contact with the same name.

Signed-off-by: Björn Baumbach <bb@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
---

diff --git a/python/samba/samdb.py b/python/samba/samdb.py
index 6d716b07c29..ec4affa24b7 100644
--- a/python/samba/samdb.py
+++ b/python/samba/samdb.py
@@ -334,6 +334,12 @@ changetype: modify
                                            expression="%s" % filter,
                                            attrs=[])
 
+                if len(targetmember) > 1:
+                    memberlist_str = ""
+                    for msg in targetmember:
+                        memberlist_str += "%s\n" % msg.get("dn")
+                    raise Exception('Found multiple results for "%s":\n%s' %
+                                    (member, memberlist_str))
                 if len(targetmember) == 0 and foreign_msg is not None:
                     targetmember = [foreign_msg]
                 if len(targetmember) != 1: