From: Roy Marples <roy@marples.name>
Date: Thu, 21 Apr 2016 19:30:19 +0000 (+0000)
Subject: Clarify the reasoning for not installing a blackhole route for a PD.
X-Git-Tag: v6.11.0~84
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=2b0856bd2c92dbcf9eafb152dc770ee9b1d94f72;p=thirdparty%2Fdhcpcd.git

Clarify the reasoning for not installing a blackhole route for a PD.
---

diff --git a/dhcp6.c b/dhcp6.c
index f93071f6..4b977867 100644
--- a/dhcp6.c
+++ b/dhcp6.c
@@ -2387,7 +2387,10 @@ dhcp6_ifdelegateaddr(struct interface *ifp, struct ipv6_addr *prefix,
 	a->prefix_len = (uint8_t)pfxlen;
 
 	/* If sla is zero and the prefix length hasn't changed,
-	 * don't install a blackhole route. */
+	 * don't install a blackhole route.
+	 * This does violate RFC3315 section 12.1, but technically
+	 * the end result is no different from assigning the entire
+	 * delegation so I'm OK with it. */
 	if (sla->sla_set && sla->sla == 0 && prefix->prefix_len == pfxlen)
 		prefix->flags |= IPV6_AF_DELEGATEDZERO;