From: Kamalesh Babulal Date: Tue, 15 Feb 2022 07:20:44 +0000 (+0530) Subject: test-021: make it PEP8 compliant X-Git-Tag: v3.1.0~308^2~2^2~82 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=2b2165de355e21730750ffe3c7e44846ad00702d;p=thirdparty%2Flibcgroup.git test-021: make it PEP8 compliant Make test 021-cgconfig-invalid_options.py PEP-8 compliant. Signed-off-by: Kamalesh Babulal Signed-off-by: Tom Hromatka --- diff --git a/ftests/021-cgconfig-invalid_options.py b/ftests/021-cgconfig-invalid_options.py index d3acda8d..3ab4c49f 100755 --- a/ftests/021-cgconfig-invalid_options.py +++ b/ftests/021-cgconfig-invalid_options.py @@ -20,12 +20,12 @@ # along with this library; if not, see . # -from cgroup import Cgroup, CgroupVersion +from cgroup import Cgroup +from run import RunError import consts import ftests -import os -from run import RunError import sys +import os CONTROLLER = 'cpuset' CGNAME = '021cgconfig' @@ -33,7 +33,7 @@ CGNAME = '021cgconfig' CONFIG_FILE = '''group {} {{ {} {{ - cpuset.cpus = abc123; + cpuset.cpus = abc123; }} }}'''.format(CGNAME, CONTROLLER) @@ -41,49 +41,54 @@ USER = 'cguser021' CONFIG_FILE_NAME = os.path.join(os.getcwd(), '021cgconfig.conf') + def prereqs(config): result = consts.TEST_PASSED cause = None return result, cause + def setup(config): f = open(CONFIG_FILE_NAME, 'w') f.write(CONFIG_FILE) f.close() + def test(config): result = consts.TEST_PASSED cause = None ret = Cgroup.configparser(config, cghelp=True) - if not "Parse and load the specified cgroups" in ret: + if 'Parse and load the specified cgroups' not in ret: result = consts.TEST_FAILED - cause = "Failed to print cgconfigparser help text" + cause = 'Failed to print cgconfigparser help text' return result, cause try: Cgroup.configparser(config, load_file=CONFIG_FILE_NAME) except RunError as re: - if not "Invalid argument" in re.stderr: + if 'Invalid argument' not in re.stderr: result = consts.TEST_FAILED cause = "Expected 'Invalid argument' to be in stderr" return result, cause if re.ret != 96: result = consts.TEST_FAILED - cause = "Expected return code of 96 but received {}".format(re.ret) + cause = 'Expected return code of 96 but received {}'.format(re.ret) return result, cause else: result = consts.TEST_FAILED - cause = "Test case erroneously passed" + cause = 'Test case erroneously passed' return result, cause return result, cause + def teardown(config): os.remove(CONFIG_FILE_NAME) + def main(config): [result, cause] = prereqs(config) if result != consts.TEST_PASSED: @@ -97,6 +102,7 @@ def main(config): return [result, cause] + if __name__ == '__main__': config = ftests.parse_args() # this test was invoked directly. run only it