From: Paolo Bonzini Date: Sun, 23 Nov 2025 17:00:55 +0000 (+0100) Subject: target/i386/tcg: move and expand misplaced comment X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=2b230c49898af33d51bc845a3a2d655b48821b8e;p=thirdparty%2Fqemu.git target/i386/tcg: move and expand misplaced comment Reviewed-by: Richard Henderson Signed-off-by: Paolo Bonzini --- diff --git a/target/i386/tcg/decode-new.c.inc b/target/i386/tcg/decode-new.c.inc index d2c024ea34..e7ffd3a984 100644 --- a/target/i386/tcg/decode-new.c.inc +++ b/target/i386/tcg/decode-new.c.inc @@ -1878,16 +1878,11 @@ static const X86OpEntry opcodes_root[256] = { #undef vex12 #undef vex13 -/* - * Decode the fixed part of the opcode and place the last - * in b. - */ static void decode_root(DisasContext *s, CPUX86State *env, X86OpEntry *entry, uint8_t *b) { *entry = opcodes_root[*b]; } - static int decode_modrm(DisasContext *s, CPUX86State *env, X86DecodedInsn *decode, X86DecodedOp *op) { @@ -2222,6 +2217,10 @@ static bool decode_insn(DisasContext *s, CPUX86State *env, X86DecodeFunc decode_ { X86OpEntry *e = &decode->e; + /* + * Each step decodes part of the opcode and leaves the last not-fully-decoded + * byte in decode->b. If the modrm byte is read, it is placed in s->modrm. + */ decode_func(s, env, e, &decode->b); while (e->is_decode) { e->is_decode = false;