From: Alejandro Colomar <alx@kernel.org>
Date: Fri, 1 Sep 2023 22:54:16 +0000 (+0200)
Subject: lib/pwauth.c: Remove dead code
X-Git-Tag: 4.15.0-rc1~183
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=2b393114c7b83ea1c9e8278be2a5a8fc94626fab;p=thirdparty%2Fshadow.git

lib/pwauth.c: Remove dead code

If the string is "", then strzero() is a no-op.  We don't need to test
that.

Signed-off-by: Alejandro Colomar <alx@kernel.org>
---

diff --git a/lib/pwauth.c b/lib/pwauth.c
index 693b3b7df..d547e53e5 100644
--- a/lib/pwauth.c
+++ b/lib/pwauth.c
@@ -202,7 +202,7 @@ int pw_auth (const char *cipher,
 	 */
 
 	clear_pass = clear;
-	if (wipe_clear_pass && (NULL != clear) && ('\0' != *clear)) {
+	if (wipe_clear_pass && (NULL != clear)) {
 		strzero (clear);
 	}
 	return retval;