From: Jan Engelhardt <jengelh@inai.de>
Date: Thu, 9 Oct 2025 20:30:24 +0000 (+0200)
Subject: tarpit: resolve argument passing order mix-up for tarpit_tg6
X-Git-Tag: v3.30~5
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=2b4116dd50398e5ecb2d2dbc4a25c512b5be63e1;p=thirdparty%2Fxtables-addons.git

tarpit: resolve argument passing order mix-up for tarpit_tg6
---

diff --git a/extensions/xt_TARPIT.c b/extensions/xt_TARPIT.c
index 0994af3..d7bb361 100644
--- a/extensions/xt_TARPIT.c
+++ b/extensions/xt_TARPIT.c
@@ -150,6 +150,10 @@ static void xttarpit_reset(struct tcphdr *tcph, const struct tcphdr *oth)
 	tcph->ack_seq = oth->seq;
 }
 
+/**
+ * @tcph: newly-being-built transport header
+ * @oth:  original transport header
+ */
 static bool tarpit_generic(struct tcphdr *tcph, const struct tcphdr *oth,
     uint16_t payload, unsigned int mode)
 {
@@ -389,7 +393,7 @@ static void tarpit_tcp6(const struct xt_action_param *par,
 	((uint8_t *)tcph)[13] = 0;
 
 	payload = nskb->len - sizeof(struct ipv6hdr) - sizeof(struct tcphdr);
-	if (!tarpit_generic(&oth, tcph, payload, mode))
+	if (!tarpit_generic(tcph, &oth, payload, mode))
 		goto free_nskb;
 
 	ip6h->payload_len = htons(sizeof(struct tcphdr));