From: Paul Querna <pquerna@apache.org>
Date: Sun, 7 Dec 2008 05:45:31 +0000 (+0000)
Subject: Don't pass in a pool to to argstr_to_table, and duplicate r->args before sending... 
X-Git-Tag: 2.3.0~8
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=2b494140a556f42c10c838223709b9193daed8a6;p=thirdparty%2Fapache%2Fhttpd.git

Don't pass in a pool to to argstr_to_table, and duplicate r->args before sending it in.


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@724080 13f79535-47bb-0310-9956-ffa450edef68
---

diff --git a/server/util_script.c b/server/util_script.c
index 0c764903baf..ff00962b768 100644
--- a/server/util_script.c
+++ b/server/util_script.c
@@ -724,7 +724,7 @@ AP_DECLARE_NONSTD(int) ap_scan_script_header_err_strs(request_rec *r,
 
 
 static void
-argstr_to_table(apr_pool_t *p, char *str, apr_table_t *parms)
+argstr_to_table(char *str, apr_table_t *parms)
 {
     char *key;
     char *value;
@@ -758,7 +758,7 @@ argstr_to_table(apr_pool_t *p, char *str, apr_table_t *parms)
 AP_DECLARE(void) ap_args_to_table(request_rec *r, apr_table_t **table)
 {
     apr_table_t *t = apr_table_make(r->pool, 10);
-    argstr_to_table(r->pool, r->args, t);
+    argstr_to_table(apr_pstrdup(r->pool, r->args), t);
     *table = t;
 }
 
@@ -821,7 +821,7 @@ AP_DECLARE(apr_status_t) ap_body_to_table(request_rec *r, apr_table_t **table)
 
                 buffer[total] = '\0';
 
-                argstr_to_table(r->pool, buffer, r->body_table);
+                argstr_to_table(buffer, r->body_table);
             }
             apr_pool_destroy(tpool);
         }