From: Samanta Navarro <ferivoz@riseup.net>
Date: Tue, 23 Jan 2024 12:04:05 +0000 (+0000)
Subject: lib/pam_pass_non_interactive.c: use strzero/free
X-Git-Tag: 4.15.1~12
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=2b67dc77651874999258c9ca4ebd57ed03cabe37;p=thirdparty%2Fshadow.git

lib/pam_pass_non_interactive.c: use strzero/free

The combination of bzero and free could be optimized away.

Reviewed-by: Alejandro Colomar <alx@kernel.org>
Signed-off-by: Samanta Navarro <ferivoz@riseup.net>
---

diff --git a/lib/pam_pass_non_interactive.c b/lib/pam_pass_non_interactive.c
index 12dad4dd1..3d10908bd 100644
--- a/lib/pam_pass_non_interactive.c
+++ b/lib/pam_pass_non_interactive.c
@@ -19,6 +19,7 @@
 
 #include "alloc.h"
 #include "attr.h"
+#include "memzero.h"
 #include "prototypes.h"
 #include "shadowlog.h"
 
@@ -97,9 +98,8 @@ static int ni_conv (int num_msg,
 failed_conversation:
 	for (count=0; count < num_msg; count++) {
 		if (NULL != responses[count].resp) {
-			bzero(responses[count].resp,
-			      strlen(responses[count].resp));
-			free (responses[count].resp);
+			strzero(responses[count].resp);
+			free(responses[count].resp);
 			responses[count].resp = NULL;
 		}
 	}