From: Mike Brady <mikebrady@eircom.net>
Date: Tue, 14 Mar 2017 09:45:06 +0000 (+0000)
Subject: Add a memory barrier after initialising the rtsp_conn record. Stop a potential race... 
X-Git-Tag: 3.1.s5~36
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=2b6a9420a92d434189df7d00fe6ad2fbc191a7f5;p=thirdparty%2Fshairport-sync.git

Add a memory barrier after initialising the rtsp_conn record. Stop a potential race condition.
---

diff --git a/rtsp.c b/rtsp.c
index ac531800..ce4dab75 100644
--- a/rtsp.c
+++ b/rtsp.c
@@ -285,9 +285,10 @@ static void cleanup_threads(void) {
   // debug(2, "culling threads.");
   for (i = 0; i < nconns;) {
     if (conns[i]->running == 0) {
+      debug(1, "found a non-running thread");
       pthread_join(conns[i]->thread, &retval);
       free(conns[i]);
-      debug(3, "one thread joined...");
+      debug(1, "one thread joined...");
       nconns--;
       if (nconns)
         conns[i] = conns[nconns];
@@ -1914,6 +1915,8 @@ void rtsp_listen_loop(void) {
       continue;
 
     rtsp_conn_info *conn = malloc(sizeof(rtsp_conn_info));
+    if (conn==0)
+      die("Couldn't allocate memory for an rtsp_conn_info record.");
     memset(conn, 0, sizeof(rtsp_conn_info));
     socklen_t slen = sizeof(conn->remote);
 
@@ -1974,14 +1977,15 @@ void rtsp_listen_loop(void) {
 
       usleep(500000);
       pthread_t rtsp_conversation_thread;
+      conn->stop = 0;
+      conn->authorized = 0;
+      conn->running = 1;
       ret = pthread_create(&rtsp_conversation_thread, NULL, rtsp_conversation_thread_func, conn);
       if (ret)
         die("Failed to create RTSP receiver thread!");
 
       conn->thread = rtsp_conversation_thread;
-      conn->stop = 0;
-      conn->authorized = 0;
-      conn->running = 1;
+      memory_barrier();
       track_thread(conn);
     }
   }