From: Philippe Antoine <pantoine@oisf.net>
Date: Wed, 17 May 2023 14:16:07 +0000 (+0200)
Subject: ssh: do not check for useless tx_id always 0
X-Git-Tag: suricata-6.0.13~35
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=2b9750a8d94da2c5c8cc77ee87f05ae0ffc3f90d;p=thirdparty%2Fsuricata-verify.git

ssh: do not check for useless tx_id always 0
---

diff --git a/tests/bug-4903/bug-4903-01/test.yaml b/tests/bug-4903/bug-4903-01/test.yaml
index 768d4a46c..61ef84932 100644
--- a/tests/bug-4903/bug-4903-01/test.yaml
+++ b/tests/bug-4903/bug-4903-01/test.yaml
@@ -28,7 +28,6 @@ checks:
       src_port: 22
       ssh.server.proto_version: '1.99'
       ssh.server.software_version: Cisco_server-1.24
-      tx_id: 0
 - filter:
     count: 1
     match:
@@ -52,7 +51,6 @@ checks:
       src_port: 22
       ssh.server.proto_version: '1.99'
       ssh.server.software_version: Cisco_server-1.24
-      tx_id: 0
 - filter:
     count: 1
     match:
@@ -64,7 +62,6 @@ checks:
       src_port: 10000
       ssh.server.proto_version: '1.99'
       ssh.server.software_version: Cisco_server-1.24
-      tx_id: 0
 - filter:
     count: 0
     match:
diff --git a/tests/bug-4903/bug-4903-02/test.yaml b/tests/bug-4903/bug-4903-02/test.yaml
index ad21e2ccd..562558f25 100644
--- a/tests/bug-4903/bug-4903-02/test.yaml
+++ b/tests/bug-4903/bug-4903-02/test.yaml
@@ -28,7 +28,6 @@ checks:
       src_port: 22
       ssh.server.proto_version: '1.99'
       ssh.server.software_version: Cisco_server-1.24
-      tx_id: 0
 - filter:
     count: 1
     match:
@@ -52,7 +51,6 @@ checks:
       src_port: 22
       ssh.server.proto_version: '1.99'
       ssh.server.software_version: Cisco_server-1.24
-      tx_id: 0
 - filter:
     count: 1
     match:
@@ -64,7 +62,6 @@ checks:
       src_port: 10001
       ssh.server.proto_version: '1.99'
       ssh.server.software_version: Cisco_server-1.24
-      tx_id: 0
 - filter:
     count: 0
     match:
diff --git a/tests/bug-4903/bug-4903-03/test.yaml b/tests/bug-4903/bug-4903-03/test.yaml
index 1f5a4464f..4397d6df8 100644
--- a/tests/bug-4903/bug-4903-03/test.yaml
+++ b/tests/bug-4903/bug-4903-03/test.yaml
@@ -30,7 +30,6 @@ checks:
       ssh.client.software_version: Cisco_client-1.25
       ssh.server.proto_version: '1.99'
       ssh.server.software_version: Cisco_server-1.24
-      tx_id: 0
 - filter:
     count: 1
     match:
@@ -56,7 +55,6 @@ checks:
       ssh.client.software_version: Cisco_client-1.25
       ssh.server.proto_version: '1.99'
       ssh.server.software_version: Cisco_server-1.24
-      tx_id: 0
 - filter:
     count: 1
     match:
@@ -70,7 +68,6 @@ checks:
       ssh.client.software_version: Cisco_client-1.25
       ssh.server.proto_version: '1.99'
       ssh.server.software_version: Cisco_server-1.24
-      tx_id: 0
 - filter:
     count: 1
     match:
@@ -96,7 +93,6 @@ checks:
       ssh.client.software_version: Cisco_client-1.25
       ssh.server.proto_version: '1.99'
       ssh.server.software_version: Cisco_server-1.24
-      tx_id: 0
 - filter:
     count: 1
     match:
@@ -122,4 +118,3 @@ checks:
       ssh.client.software_version: Cisco_client-1.25
       ssh.server.proto_version: '1.99'
       ssh.server.software_version: Cisco_server-1.24
-      tx_id: 0
diff --git a/tests/bug-4903/bug-4903-04/test.yaml b/tests/bug-4903/bug-4903-04/test.yaml
index ce7e992d8..4ef142345 100644
--- a/tests/bug-4903/bug-4903-04/test.yaml
+++ b/tests/bug-4903/bug-4903-04/test.yaml
@@ -31,7 +31,6 @@ checks:
       ssh.client.software_version: Cisco_client-1.25
       ssh.server.proto_version: '1.99'
       ssh.server.software_version: Cisco_server-1.24
-      tx_id: 0
 - filter:
     count: 1
     match:
@@ -58,7 +57,6 @@ checks:
       ssh.client.software_version: Cisco_client-1.25
       ssh.server.proto_version: '1.99'
       ssh.server.software_version: Cisco_server-1.24
-      tx_id: 0
 - filter:
     count: 1
     match:
@@ -73,7 +71,6 @@ checks:
       ssh.client.software_version: Cisco_client-1.25
       ssh.server.proto_version: '1.99'
       ssh.server.software_version: Cisco_server-1.24
-      tx_id: 0
 - filter:
     count: 1
     match:
@@ -100,7 +97,6 @@ checks:
       ssh.client.software_version: Cisco_client-1.25
       ssh.server.proto_version: '1.99'
       ssh.server.software_version: Cisco_server-1.24
-      tx_id: 0
 - filter:
     count: 1
     match:
@@ -127,4 +123,3 @@ checks:
       ssh.client.software_version: Cisco_client-1.25
       ssh.server.proto_version: '1.99'
       ssh.server.software_version: Cisco_server-1.24
-      tx_id: 0