From: Jerome Forissier <jerome.forissier@linaro.org>
Date: Thu, 24 Jul 2025 09:12:40 +0000 (+0200)
Subject: binman: bintool: use apt-get instead of apt
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=2babd34eacfb12f799f8d52a8729139041a18680;p=thirdparty%2Fu-boot.git

binman: bintool: use apt-get instead of apt

The 'apt' command is not meant to be used in scripts or tools. Please
see the man page [1] for details. Therefore, use 'apt-get' instead.
This avoids the following warning:

WARNING: apt does not have a stable CLI interface. Use with caution in scripts.

[1] https://manpages.debian.org/bookworm/apt/apt.8.en.html#SCRIPT_USAGE_AND_DIFFERENCES_FROM_OTHER_APT_TOOLS

Signed-off-by: Jerome Forissier <jerome.forissier@linaro.org>
Reviewed-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
Reviewed-by: Bryan Brattlof <bb@ti.com>
---

diff --git a/tools/binman/bintool.py b/tools/binman/bintool.py
index 81872db377f..f46bb52a7b3 100644
--- a/tools/binman/bintool.py
+++ b/tools/binman/bintool.py
@@ -421,7 +421,7 @@ class Bintool:
         Returns:
             True, assuming it completes without error
         """
-        args = ['sudo', 'apt', 'install', '-y', package]
+        args = ['sudo', 'apt-get', 'install', '-y', package]
         print('- %s' % ' '.join(args))
         tools.run(*args)
         return True