From: Victor Julien <vjulien@oisf.net>
Date: Mon, 27 Feb 2023 14:41:36 +0000 (+0100)
Subject: flow: remove unused tcp reuse flow flag
X-Git-Tag: suricata-7.0.0-rc2~549
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=2bb1e5a38ab1ec6fe431fb0dfca99b343104bdd9;p=thirdparty%2Fsuricata.git

flow: remove unused tcp reuse flow flag
---

diff --git a/src/flow-hash.c b/src/flow-hash.c
index 89180d7ad8..d90c32889c 100644
--- a/src/flow-hash.c
+++ b/src/flow-hash.c
@@ -695,8 +695,6 @@ static Flow *TcpReuseReplace(ThreadVars *tv, FlowLookupStruct *fls, FlowBucket *
 #ifdef UNITTESTS
     }
 #endif
-    /* tag flow as reused so future lookups won't find it */
-    old_f->flags |= FLOW_TCP_REUSED;
     /* time out immediately */
     old_f->timeout_at = 0;
     /* get some settings that we move over to the new flow */
diff --git a/src/flow.h b/src/flow.h
index de8d21f97e..c0a91e5f11 100644
--- a/src/flow.h
+++ b/src/flow.h
@@ -50,8 +50,8 @@ typedef struct AppLayerParserState_ AppLayerParserState;
 #define FLOW_TO_SRC_SEEN                BIT_U32(0)
 /** At least one packet from the destination address was seen */
 #define FLOW_TO_DST_SEEN                BIT_U32(1)
-/** Don't return this from the flow hash. It has been replaced. */
-#define FLOW_TCP_REUSED                 BIT_U32(2)
+
+// vacancy
 
 /** Flow was inspected against IP-Only sigs in the toserver direction */
 #define FLOW_TOSERVER_IPONLY_SET        BIT_U32(3)