From: Michael Tremer <michael.tremer@ipfire.org>
Date: Thu, 19 Aug 2021 14:34:29 +0000 (+0000)
Subject: archive: Generate a more useful log message when verification fails
X-Git-Tag: 0.9.28~994
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=2bcdb54474248f424c26f4686ff81a33692b3518;p=pakfire.git

archive: Generate a more useful log message when verification fails

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>
---

diff --git a/src/libpakfire/archive.c b/src/libpakfire/archive.c
index bf18e8b16..a4cef2bb0 100644
--- a/src/libpakfire/archive.c
+++ b/src/libpakfire/archive.c
@@ -1602,6 +1602,10 @@ PAKFIRE_EXPORT int pakfire_archive_verify(struct pakfire_archive* archive,
 	// Store result
 	*status = archive->verify;
 
+	// Log error
+	ERROR(archive->pakfire, "Archive verification for %s has failed: %s\n",
+		archive->path, pakfire_archive_verify_strerror(archive->verify));
+
 	return 0;
 
 ERROR:
diff --git a/src/libpakfire/transaction.c b/src/libpakfire/transaction.c
index 923541662..4315f420c 100644
--- a/src/libpakfire/transaction.c
+++ b/src/libpakfire/transaction.c
@@ -595,8 +595,6 @@ static int pakfire_transaction_verify(struct pakfire_transaction* transaction,
 
 		// Bad
 		default:
-			ERROR(transaction->pakfire, "Archive verification failed: %s\n",
-				pakfire_archive_verify_strerror(status));
 			break;
 	}