From: Florian Weimer <fweimer@redhat.com>
Date: Wed, 15 Mar 2017 12:14:54 +0000 (+0100)
Subject: support: Explain ignored failures of temporary file removal [BZ #21243]
X-Git-Tag: glibc-2.26~712
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=2bda2d820dcd9ea382b7380c18d469c23232fbbf;p=thirdparty%2Fglibc.git

support: Explain ignored failures of temporary file removal [BZ #21243]
---

diff --git a/ChangeLog b/ChangeLog
index c9a9a89827f..2d489f041a1 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,9 @@
+2017-03-15  Florian Weimer  <fweimer@redhat.com>
+
+	[BZ #21243]
+	* support/temp_file.c (support_delete_temp_files): Add comment
+	about ignored errors.
+
 2017-03-15  Florian Weimer  <fweimer@redhat.com>
 
 	[BZ #21244]
diff --git a/support/temp_file.c b/support/temp_file.c
index f06647a467f..5950aec06b6 100644
--- a/support/temp_file.c
+++ b/support/temp_file.c
@@ -99,7 +99,10 @@ support_delete_temp_files (void)
 {
   while (temp_name_list != NULL)
     {
-      remove (temp_name_list->name);
+      /* For some tests, the temporary file removal runs multiple
+	 times (in the parent processes and the subprocess), so do not
+	 report a failed removal attempt.  */
+      (void) remove (temp_name_list->name);
       free (temp_name_list->name);
 
       struct temp_name_list *next