From: Alex Rousskov <rousskov@measurement-factory.com>
Date: Thu, 18 Feb 2016 04:15:33 +0000 (-0700)
Subject: Better handling of huge response headers. Fewer "BUG 3279" messages.
X-Git-Tag: SQUID_3_5_15~6
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=2bdd9e7c867ed597f2beb0f246beac7761cb3acf;p=thirdparty%2Fsquid.git

Better handling of huge response headers. Fewer "BUG 3279" messages.

When we failed to parse a response, do not store the fake half-baked
response (via a replaceHttpReply() call). Doing so leads to misleading
"BUG 3279: HTTP reply without Date" messages (at best).  The fake
response is only meant for continueAfterParsingHeader().

Also removed a misleading XXX that may have caused Bug 4432 in v4.0
(trunk r14548).
---

diff --git a/src/http.cc b/src/http.cc
index 72eb94bef6..178b380821 100644
--- a/src/http.cc
+++ b/src/http.cc
@@ -719,11 +719,8 @@ HttpStateData::processReplyHeader()
         if (!parsed && error > 0) { // unrecoverable parsing error
             debugs(11, 3, "processReplyHeader: Non-HTTP-compliant header: '" <<  readBuf->content() << "'");
             flags.headers_parsed = true;
-            // XXX: when sanityCheck is gone and Http::StatusLine is used to parse,
-            //   the sline should be already set the appropriate values during that parser stage
             newrep->sline.set(Http::ProtocolVersion(1,1), error);
-            HttpReply *vrep = setVirginReply(newrep);
-            entry->replaceHttpReply(vrep);
+            setVirginReply(newrep);
             ctx_exit(ctx);
             return;
         }