From: Stefano Lattarini <stefano.lattarini@gmail.com>
Date: Sun, 13 Jun 2010 20:37:39 +0000 (+0200)
Subject: Add useful comment in test script ext.test.
X-Git-Tag: v1.11.1b~72^2~1
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=2be348413512b885042fe11f35f58a3bcdbc4894;p=thirdparty%2Fautomake.git

Add useful comment in test script ext.test.

* tests/ext.test: Add a comment explaining why an apparently
useless `if' statement is indeed required.
---

diff --git a/ChangeLog b/ChangeLog
index 6174ee019..c9a7defea 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,5 +1,9 @@
 2010-06-13  Stefano Lattarini  <stefano.lattarini@gmail.com>
 
+	Add useful comment in test script ext.test.
+	* tests/ext.test: Add a comment explaining why an apparently
+	useless `if' statement is indeed required.
+
 	Add useful comment in test script obsolete.test.
 	* tests/obsolte.test: Add a comment explaining why we need
 	an indirection in adding $AUTOUPDATE to $required.
diff --git a/tests/ext.test b/tests/ext.test
index 934067390..af2eab281 100755
--- a/tests/ext.test
+++ b/tests/ext.test
@@ -38,6 +38,10 @@ $AUTOMAKE
 
 for ext in f for f90 f95 F F90 F95 r m upc
 do
+   # Some versions of the BSD shell wrongly exit when `set -e' is active
+   # if the last command within a compound statement fails and is guarded
+   # by an && only.  So we play safe and use the following idiom, instead
+   # of the apparently simpler `grep ... && Exit 1'.
    if grep "^$ext\.o:" Makefile.in; then Exit 1; else :; fi
    grep "^\.$ext\.o:" Makefile.in
 done