From: Aki Tuomi <cmouse@cmouse.fi>
Date: Tue, 20 Feb 2018 06:19:33 +0000 (+0200)
Subject: pdnsutil: Check that hsm was provided a sub-command
X-Git-Tag: dnsdist-1.3.0~73^2~1
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=2be60de772e59c5d96f9a019f2174393620213c2;p=thirdparty%2Fpdns.git

pdnsutil: Check that hsm was provided a sub-command

Fixes signal 11 crash due to null pointer comparison
---

diff --git a/pdns/pdnsutil.cc b/pdns/pdnsutil.cc
index 9031a263ef..1281bbccf1 100644
--- a/pdns/pdnsutil.cc
+++ b/pdns/pdnsutil.cc
@@ -2901,7 +2901,10 @@ try
   } else if (cmds[0]=="hsm") {
 #ifdef HAVE_P11KIT1
     UeberBackend B("default");
-    if (cmds[1] == "assign") {
+    if (cmds.size() < 2) {
+      cerr << "Missing sub-command for pdnsutil hsm"<< std::endl;
+      return 0;
+    } else if (cmds[1] == "assign") {
       DNSCryptoKeyEngine::storvector_t storvect;
       DomainInfo di;
       std::vector<DNSBackend::KeyData> keys;