From: Noel Power Date: Wed, 22 May 2019 09:37:40 +0000 (+0000) Subject: s4/rpc_server/dnsserver: cppcheck: Fix Uninitialized variable error. X-Git-Tag: ldb-2.0.5~512 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=2bed937e7fbb551bebfed3c76d7bf4317f72b425;p=thirdparty%2Fsamba.git s4/rpc_server/dnsserver: cppcheck: Fix Uninitialized variable error. source4/rpc_server/dnsserver/dcerpc_dnsserver.c:715: error: uninitvar: Uninitialized variable: answer_integer <--[cppcheck] This error is benign and somewhat false because the code pointed to does not run (due to a different check) if answer_integer is not actually initialsed. It is easy to squash it though by just initialising the var. Signed-off-by: Noel Power Reviewed-by: Andreas Schneider --- diff --git a/source4/rpc_server/dnsserver/dcerpc_dnsserver.c b/source4/rpc_server/dnsserver/dcerpc_dnsserver.c index 841557814a0..1bb46a58339 100644 --- a/source4/rpc_server/dnsserver/dcerpc_dnsserver.c +++ b/source4/rpc_server/dnsserver/dcerpc_dnsserver.c @@ -374,6 +374,7 @@ static WERROR dnsserver_query_server(struct dnsserver_state *dsstate, } is_integer = 0; + answer_integer = 0; if (strcasecmp(operation, "AddressAnswerLimit") == 0) { answer_integer = serverinfo->cAddressAnswerLimit; @@ -834,7 +835,7 @@ static WERROR dnsserver_query_zone(struct dnsserver_state *dsstate, union DNSSRV_RPC_UNION *r) { uint8_t is_integer, is_addresses, is_string; - uint32_t answer_integer; + uint32_t answer_integer = 0; struct IP4_ARRAY *answer_iparray; struct DNS_ADDR_ARRAY *answer_addrarray; char *answer_string;