From: Andrew Bartlett <abartlet@samba.org>
Date: Mon, 18 Oct 2021 07:44:54 +0000 (+1300)
Subject: selftest: Remove duplicate setup of $base_dn and $ldbmodify
X-Git-Tag: ldb-2.5.0~374
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=2c0658d408f17af2abc223b0cb18d8d33e0ecd1a;p=thirdparty%2Fsamba.git

selftest: Remove duplicate setup of $base_dn and $ldbmodify

These are already set up to the same values above for the full
DC and correct values for the (strange) s4member environment.

By not setting $base_dn again we avoid an error once we start
checking for them.

Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
---

diff --git a/selftest/target/Samba4.pm b/selftest/target/Samba4.pm
index a4f1043ec51..abb387b7527 100755
--- a/selftest/target/Samba4.pm
+++ b/selftest/target/Samba4.pm
@@ -1116,10 +1116,6 @@ servicePrincipalName: http/testupnspn.$ctx->{dnsname}
 	}
 
 	# Change the userPrincipalName for jane
-	$ldbmodify = ${cmd_env};
-	$ldbmodify .= Samba::bindir_path($self, "ldbmodify");
-	$ldbmodify .=  " --configfile=$ctx->{smb_conf}";
-	$base_dn = "DC=".join(",DC=", split(/\./, $ctx->{realm}));
 	$user_dn = "cn=jane,cn=users,$base_dn";
 
 	open(LDIF, "|$ldbmodify -H $ctx->{privatedir}/sam.ldb");