From: Rohan Dutta <quic_drohan@quicinc.com>
Date: Fri, 11 Apr 2025 14:59:09 +0000 (+0530)
Subject: Remove redundant management group cipher suite selector writing
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=2c0e21ef27c64412986883360878217cf452cd88;p=thirdparty%2Fhostap.git

Remove redundant management group cipher suite selector writing

Remove the default BIP (AES-128-CMAC) from the code writing the group
management cipher selector into an RSNE since this field is omitted when
the default value is used. This case was unreachable due to the earlier
if statement skipping this switch statement.

Signed-off-by: Rohan Dutta <quic_drohan@quicinc.com>
---

diff --git a/src/ap/wpa_auth_ie.c b/src/ap/wpa_auth_ie.c
index 2e5f59ec1..83ae4e065 100644
--- a/src/ap/wpa_auth_ie.c
+++ b/src/ap/wpa_auth_ie.c
@@ -346,9 +346,6 @@ static u8 * rsne_write_data(u8 *buf, size_t len, u8 *pos, int group,
 
 		/* Management Group Cipher Suite */
 		switch (group_mgmt_cipher) {
-		case WPA_CIPHER_AES_128_CMAC:
-			RSN_SELECTOR_PUT(pos, RSN_CIPHER_SUITE_AES_128_CMAC);
-			break;
 		case WPA_CIPHER_BIP_GMAC_128:
 			RSN_SELECTOR_PUT(pos, RSN_CIPHER_SUITE_BIP_GMAC_128);
 			break;