From: Francis Dupont <fdupont@isc.org>
Date: Thu, 17 Sep 2020 14:23:51 +0000 (+0200)
Subject: [#1333] Improved comment
X-Git-Tag: Kea-1.9.0~92
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=2c2dfd8f0c9c399991727550bd5703eca426df02;p=thirdparty%2Fkea.git

[#1333] Improved comment
---

diff --git a/src/bin/dhcp4/dhcp4_srv.cc b/src/bin/dhcp4/dhcp4_srv.cc
index f5b1a4a311..559e7a4374 100644
--- a/src/bin/dhcp4/dhcp4_srv.cc
+++ b/src/bin/dhcp4/dhcp4_srv.cc
@@ -221,7 +221,9 @@ Dhcpv4Exchange::Dhcpv4Exchange(const AllocEnginePtr& alloc_engine,
             CfgMgr::instance().getCurrentCfg()->getClientClassDictionary();
         const ClientClassDefListPtr& defs_ptr = dict->getClasses();
         for (auto def : *defs_ptr) {
-            // Only remove evaluated classes.
+            // Only remove evaluated classes. Other classes can be
+            // assigned via hooks libraries and we should not remove
+            // them because there is no way they can be added back.
             if (def->getMatchExpr()) {
                 context_->query_->classes_.erase(def->getName());
             }
diff --git a/src/bin/dhcp6/dhcp6_srv.cc b/src/bin/dhcp6/dhcp6_srv.cc
index 75a60d0a3b..2b0caf36f5 100644
--- a/src/bin/dhcp6/dhcp6_srv.cc
+++ b/src/bin/dhcp6/dhcp6_srv.cc
@@ -471,7 +471,9 @@ Dhcpv6Srv::initContext(const Pkt6Ptr& pkt,
             CfgMgr::instance().getCurrentCfg()->getClientClassDictionary();
         const ClientClassDefListPtr& defs_ptr = dict->getClasses();
         for (auto def : *defs_ptr) {
-            // Only remove evaluated classes.
+            // Only remove evaluated classes. Other classes can be
+            // assigned via hooks libraries and we should not remove
+            // them because there is no way they can be added back.
             if (def->getMatchExpr()) {
                 ctx.query_->classes_.erase(def->getName());
             }