From: Krzysztof Kozlowski Date: Thu, 24 Apr 2025 20:33:09 +0000 (+0200) Subject: firmware: exynos-acpm: Correct kerneldoc and use typical np argument name X-Git-Tag: v6.16-rc1~63^2~56^2 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=2c2e5e908ea2b53aa0d21fbfe4d1dab527a7703e;p=thirdparty%2Flinux.git firmware: exynos-acpm: Correct kerneldoc and use typical np argument name Correct kerneldoc warnings after commit a8dc26a0ec43 ("firmware: exynos-acpm: introduce devm_acpm_get_by_node()") changed the function prototype: exynos-acpm.c:672: warning: Function parameter or struct member 'acpm_np' not described in 'acpm_get_by_node' exynos-acpm.c:672: warning: expecting prototype for acpm_get_by_phandle(). Prototype was for acpm_get_by_node() instead While touching the lines, change the name of device_node pointer to 'np' to match convention. Fixes: a8dc26a0ec43 ("firmware: exynos-acpm: introduce devm_acpm_get_by_node()") Reported-by: kernel test robot Closes: https://lore.kernel.org/oe-kbuild-all/202504222051.7TqaSQ48-lkp@intel.com/ Reviewed-by: Tudor Ambarus Link: https://lore.kernel.org/r/20250424203308.402168-2-krzysztof.kozlowski@linaro.org Signed-off-by: Krzysztof Kozlowski --- diff --git a/drivers/firmware/samsung/exynos-acpm.c b/drivers/firmware/samsung/exynos-acpm.c index 93f87cd90f249..5266b66a32e12 100644 --- a/drivers/firmware/samsung/exynos-acpm.c +++ b/drivers/firmware/samsung/exynos-acpm.c @@ -661,20 +661,20 @@ static void devm_acpm_release(struct device *dev, void *res) } /** - * acpm_get_by_phandle() - get the ACPM handle using DT phandle. - * @dev: device pointer requesting ACPM handle. - * @property: property name containing phandle on ACPM node. + * acpm_get_by_node() - get the ACPM handle using node pointer. + * @dev: device pointer requesting ACPM handle. + * @np: ACPM device tree node. * * Return: pointer to handle on success, ERR_PTR(-errno) otherwise. */ static const struct acpm_handle *acpm_get_by_node(struct device *dev, - struct device_node *acpm_np) + struct device_node *np) { struct platform_device *pdev; struct device_link *link; struct acpm_info *acpm; - pdev = of_find_device_by_node(acpm_np); + pdev = of_find_device_by_node(np); if (!pdev) return ERR_PTR(-EPROBE_DEFER);