From: Eric Sandeen Date: Sat, 26 Jan 2013 22:40:27 +0000 (+0000) Subject: libxfs: fix setup_cursor array allocation X-Git-Tag: v3.1.11~17 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=2c2e994d0a1b972d020d7633202bf2f4cfc9f91b;p=thirdparty%2Fxfsprogs-dev.git libxfs: fix setup_cursor array allocation setup_cursor() wants an array of xfs_agbno_t's, but it allocated a multiple of *pointers* to xfs_agbno_t's. xfs_agbno_t is 4 bytes, so this is harmless other than allocating twice as much memory as needed on a 64-bit machine. Signed-off-by: Eric Sandeen Reviewed-by: Mark Tinguely Signed-off-by: Mark Tinguely --- diff --git a/repair/phase5.c b/repair/phase5.c index 7d5cd49a1..1f71caca5 100644 --- a/repair/phase5.c +++ b/repair/phase5.c @@ -206,7 +206,7 @@ setup_cursor(xfs_mount_t *mp, xfs_agnumber_t agno, bt_status_t *curs) ASSERT(big_extent_len > 0); - if ((curs->btree_blocks = malloc(sizeof(xfs_agblock_t *) + if ((curs->btree_blocks = malloc(sizeof(xfs_agblock_t) * big_extent_len)) == NULL) do_error(_("could not set up btree block array\n"));