From: Francesco Chemolli <5175948+kinkie@users.noreply.github.com>
Date: Thu, 2 May 2024 00:56:41 +0000 (+0000)
Subject: Optimization: clientStreamInit() copied ClientStreamData (#1801)
X-Git-Tag: SQUID_7_0_1~128
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=2c3d6a4ee3f42bc5026d7a41a9fee8ae7dc8cb42;p=thirdparty%2Fsquid.git

Optimization: clientStreamInit() copied ClientStreamData (#1801)

Detected by Coverity. CID 1529543 and CID 1529594: Unnecessary object
copies can affect performance (COPY_INSTEAD_OF_MOVE).
---

diff --git a/src/clientStream.cc b/src/clientStream.cc
index ecc316aacf..cb28bdcfcd 100644
--- a/src/clientStream.cc
+++ b/src/clientStream.cc
@@ -110,7 +110,7 @@ clientStreamNode::~clientStreamNode()
  */
 void
 clientStreamInit(dlink_list * list, CSR * func, CSD * rdetach, CSS * readstatus,
-                 ClientStreamData readdata, CSCB * callback, CSD * cdetach, ClientStreamData callbackdata,
+                 const ClientStreamData &readdata, CSCB * callback, CSD * cdetach, const ClientStreamData &callbackdata,
                  StoreIOBuffer tailBuffer)
 {
     clientStreamNode *temp = new clientStreamNode(func, nullptr, rdetach, readstatus, readdata);
diff --git a/src/clientStream.h b/src/clientStream.h
index 49a1068385..a64ffcf1b7 100644
--- a/src/clientStream.h
+++ b/src/clientStream.h
@@ -95,7 +95,7 @@ public:
 };
 
 /// \ingroup ClientStreamAPI
-void clientStreamInit(dlink_list *, CSR *, CSD *, CSS *, ClientStreamData, CSCB *, CSD *, ClientStreamData, StoreIOBuffer tailBuffer);
+void clientStreamInit(dlink_list *, CSR *, CSD *, CSS *, const ClientStreamData &, CSCB *, CSD *, const ClientStreamData &, StoreIOBuffer tailBuffer);
 
 /// \ingroup ClientStreamAPI
 void clientStreamInsertHead(dlink_list *, CSR *, CSCB *, CSD *, CSS *, ClientStreamData);