From: Oleksiy ("Alex") SEMENYAKA <219867960+alexsemenyaka@users.noreply.github.com>
Date: Mon, 21 Jul 2025 20:32:54 +0000 (+0300)
Subject: Fix: Allow tuple in nameservers type check (#1209)
X-Git-Tag: v2.8.0rc1~25
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=2c5c191104aaba0a492b90f8c057fc2727515a46;p=thirdparty%2Fdnspython.git

Fix: Allow tuple in nameservers type check (#1209)

* Fix: Allow tuple in nameservers type check

* Update resolver.py

Add missing space.

* Update documentation.

---------

Co-authored-by: Alex Semenyaka <alex.semenyaka@gmail.com>
Co-authored-by: Brian Wellington <bwelling@xbill.org>
---

diff --git a/dns/resolver.py b/dns/resolver.py
index 47e2556b..fef9e84a 100644
--- a/dns/resolver.py
+++ b/dns/resolver.py
@@ -1190,7 +1190,7 @@ class BaseResolver:
         default_port: int,
     ) -> List[dns.nameserver.Nameserver]:
         enriched_nameservers = []
-        if isinstance(nameservers, list):
+        if isinstance(nameservers, (list, tuple)):
             for nameserver in nameservers:
                 enriched_nameserver: dns.nameserver.Nameserver
                 if isinstance(nameserver, dns.nameserver.Nameserver):
@@ -1229,7 +1229,7 @@ class BaseResolver:
         self, nameservers: Sequence[Union[str, dns.nameserver.Nameserver]]
     ) -> None:
         """
-        *nameservers*, a ``list`` of nameservers, where a nameserver is either
+        *nameservers*, a ``list`` or ``tuple`` of nameservers, where a nameserver is either
         a string interpretable as a nameserver, or a ``dns.nameserver.Nameserver``
         instance.