From: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Date: Mon, 29 Mar 2021 00:10:50 +0000 (+1300)
Subject: dns scavenging: avoid setting same flags twice
X-Git-Tag: tevent-0.11.0~296
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=2c6a0265f2b577be485744edc5e8951f31d7ecfd;p=thirdparty%2Fsamba.git

dns scavenging: avoid setting same flags twice

We already did this with db_msg_add_empty(), ~20 lines up.

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
---

diff --git a/source4/dsdb/kcc/scavenge_dns_records.c b/source4/dsdb/kcc/scavenge_dns_records.c
index 4ff46196d79..c64580717c9 100644
--- a/source4/dsdb/kcc/scavenge_dns_records.c
+++ b/source4/dsdb/kcc/scavenge_dns_records.c
@@ -229,8 +229,6 @@ NTSTATUS dns_tombstone_records_zone(TALLOC_CTX *mem_ctx,
 			continue;
 		}
 
-		el->flags = LDB_FLAG_MOD_ADD;
-
 		/* If everything was expired, we tombstone the node. */
 		if (el->num_values == 0) {
 			el->values = tombstone_blob;