From: Jason Merrill Date: Wed, 19 Oct 2011 22:21:15 +0000 (-0400) Subject: re PR c++/50793 (G++ doesn't value-initialize all members of non-trivial type in... X-Git-Tag: releases/gcc-4.4.7~204 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=2c777ba2937c00306590c4e5ebc9bccb2f77150b;p=thirdparty%2Fgcc.git re PR c++/50793 (G++ doesn't value-initialize all members of non-trivial type in default argument) PR c++/50793 * tree.c (bot_manip): Propagate AGGR_INIT_ZERO_FIRST. From-SVN: r180223 --- diff --git a/gcc/cp/ChangeLog b/gcc/cp/ChangeLog index 3797b3a7a270..7276a3f2d63f 100644 --- a/gcc/cp/ChangeLog +++ b/gcc/cp/ChangeLog @@ -1,3 +1,8 @@ +2011-10-19 Jason Merrill + + PR c++/50793 + * tree.c (bot_manip): Propagate AGGR_INIT_ZERO_FIRST. + 2011-10-13 Jason Merrill PR c++/50618 diff --git a/gcc/cp/tree.c b/gcc/cp/tree.c index dcf9872d346a..01f4b6a031fc 100644 --- a/gcc/cp/tree.c +++ b/gcc/cp/tree.c @@ -1536,7 +1536,11 @@ bot_manip (tree* tp, int* walk_subtrees, void* data) tree u; if (TREE_CODE (TREE_OPERAND (t, 1)) == AGGR_INIT_EXPR) - u = build_cplus_new (TREE_TYPE (t), TREE_OPERAND (t, 1)); + { + u = build_cplus_new (TREE_TYPE (t), TREE_OPERAND (t, 1)); + if (AGGR_INIT_ZERO_FIRST (TREE_OPERAND (t, 1))) + AGGR_INIT_ZERO_FIRST (TREE_OPERAND (u, 1)) = true; + } else u = build_target_expr_with_type (TREE_OPERAND (t, 1), TREE_TYPE (t)); diff --git a/gcc/testsuite/ChangeLog b/gcc/testsuite/ChangeLog index 474b7283fae5..c1a4ebeca866 100644 --- a/gcc/testsuite/ChangeLog +++ b/gcc/testsuite/ChangeLog @@ -1,3 +1,8 @@ +2011-10-19 Jason Merrill + + PR c++/50793 + * g++.dg/init/value9.C: New. + 2011-10-15 Janus Weil PR fortran/50659 diff --git a/gcc/testsuite/g++.dg/init/value9.C b/gcc/testsuite/g++.dg/init/value9.C new file mode 100644 index 000000000000..4899bd81001a --- /dev/null +++ b/gcc/testsuite/g++.dg/init/value9.C @@ -0,0 +1,32 @@ +// PR c++/50793 +// { dg-do run } + +struct NonTrivial +{ + NonTrivial() { } +}; + +struct S +{ + NonTrivial nt; + int i; +}; + +int f(S s) +{ + s.i = 0xdeadbeef; + return s.i; +} + +int g(S s = S()) +{ + return s.i; +} + +int main() +{ + f(S()); // make stack dirty + + if ( g() ) + __builtin_abort(); +}