From: Nick Porter <nick@portercomputing.co.uk>
Date: Mon, 10 Feb 2025 15:17:43 +0000 (+0000)
Subject: Terminate after each control is created
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=2ca15f053f42b0ececa0c39a72c1ff74f3d14fbb;p=thirdparty%2Ffreeradius-server.git

Terminate after each control is created

So error clearup, will find a terminated array of controls
---

diff --git a/src/lib/ldap/util.c b/src/lib/ldap/util.c
index d231d8fe4cd..ec892ca8e6f 100644
--- a/src/lib/ldap/util.c
+++ b/src/lib/ldap/util.c
@@ -362,7 +362,7 @@ int fr_ldap_parse_url_extensions(LDAPControl **sss, size_t sss_len, char *extens
 				goto error;
 			}
 			sss_p++;
-
+			*sss_p = NULL;	/* Terminate */
 			continue;
 		}
 
@@ -417,6 +417,7 @@ int fr_ldap_parse_url_extensions(LDAPControl **sss, size_t sss_len, char *extens
 			}
 
 			sss_p++;
+			*sss_p = NULL;	/* Terminate */
 			continue;
 		}
 
@@ -424,8 +425,6 @@ int fr_ldap_parse_url_extensions(LDAPControl **sss, size_t sss_len, char *extens
 		return -1;
 	}
 
-	*sss_p = NULL;	/* Terminate */
-
 	return (sss_end - sss_p);
 }