From: Stefan Eissing <stefan@eissing.org>
Date: Wed, 6 Mar 2024 11:09:05 +0000 (+0100)
Subject: http: fix dead code in setting post client reader
X-Git-Tag: curl-8_7_0~75
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=2ca530d2fa649f8a7212c77218870ae456a914ce;p=thirdparty%2Fcurl.git

http: fix dead code in setting post client reader

- postsize was always 0, thus the check's else never happened
  after the mime client reader was introduced

Follow-up to 0ba47146f7ff3d
Closes #13060
---

diff --git a/lib/http.c b/lib/http.c
index 88746eb579..d50b099c77 100644
--- a/lib/http.c
+++ b/lib/http.c
@@ -1997,7 +1997,6 @@ CURLcode Curl_http_target(struct Curl_easy *data,
 #if !defined(CURL_DISABLE_MIME) || !defined(CURL_DISABLE_FORM_API)
 static CURLcode set_post_reader(struct Curl_easy *data, Curl_HttpReq httpreq)
 {
-  curl_off_t postsize = 0;
   CURLcode result;
 
   switch(httpreq) {
@@ -2066,12 +2065,9 @@ static CURLcode set_post_reader(struct Curl_easy *data, Curl_HttpReq httpreq)
     }
     data->state.infilesize = Curl_creader_total_length(data);
     return result;
+
   default:
-    if(!postsize)
-      result = Curl_creader_set_null(data);
-    else
-      result = Curl_creader_set_fread(data, postsize);
-    return result;
+    return Curl_creader_set_null(data);
   }
   /* never reached */
 }