From: Mike Stepanek (mstepane) <mstepane@cisco.com>
Date: Wed, 8 Jun 2022 10:19:22 +0000 (+0000)
Subject: Pull request #3459: wizard: Use const reference instead of copying
X-Git-Tag: 3.1.32.0~12
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=2cb59a1f75a6d5c37f7656883d711df67d4f058f;p=thirdparty%2Fsnort3.git

Pull request #3459: wizard: Use const reference instead of copying

Merge in SNORT/snort3 from ~DKYRYLOV/snort3:wizard_vtune_perf_fix to master

Squashed commit of the following:

commit b08b178af712f78da901496e6252b21f0c4037e8
Author: dkyrylov <dkyrylov@cisco.com>
Date:   Tue Jun 7 13:04:19 2022 +0300

    wizard: use const reference instead of copying
---

diff --git a/src/service_inspectors/wizard/wizard.cc b/src/service_inspectors/wizard/wizard.cc
index 48cff8bba..68e650591 100644
--- a/src/service_inspectors/wizard/wizard.cc
+++ b/src/service_inspectors/wizard/wizard.cc
@@ -276,9 +276,7 @@ void Wizard::reset(Wand& w, bool tcp, bool c2s)
 
     if ( w.curse_tracker.empty() )
     {
-        vector<const CurseDetails*> pages = curses->get_curses(tcp);
-
-        for ( const CurseDetails* curse : pages )
+        for ( const CurseDetails* curse : curses->get_curses(tcp) )
         {
             if ( tcp )
                 w.curse_tracker.emplace_back( CurseServiceTracker{ curse, new CurseTracker } );