From: Willy Tarreau <w@1wt.eu>
Date: Fri, 22 Jan 2021 14:58:26 +0000 (+0100)
Subject: BUILD: debug: fix build warning by consuming the write() result
X-Git-Tag: v2.4-dev6~3
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=2cbe2e7f84a680f30383c2fee38577091e4394a9;p=thirdparty%2Fhaproxy.git

BUILD: debug: fix build warning by consuming the write() result

When writing commit a8459b28c ("MINOR: debug: create
ha_backtrace_to_stderr() to dump an instant backtrace") I just forgot
that some distros are a bit extremist about the syscall return values.

  src/debug.c: In function `ha_backtrace_to_stderr':
  src/debug.c:147:3: error: ignoring return value of `write', declared with attribute warn_unused_result [-Werror=unused-result]
     write(2, b.area, b.data);
     ^~~~~~~~~~~~~~~~~~~~~~~~
    CC      src/h1_htx.o

Let's apply the usual tricks to shut them up. No backport is needed.
---

diff --git a/src/debug.c b/src/debug.c
index fc2de92f07..bf64f19f05 100644
--- a/src/debug.c
+++ b/src/debug.c
@@ -144,7 +144,7 @@ void ha_backtrace_to_stderr()
 
 	ha_dump_backtrace(&b, "  ", 4);
 	if (b.data)
-		write(2, b.area, b.data);
+		DISGUISE(write(2, b.area, b.data));
 }
 
 /* Dumps to the buffer some known information for the desired thread, and