From: Alan T. DeKok <aland@freeradius.org>
Date: Sun, 4 Oct 2020 00:41:23 +0000 (-0400)
Subject: remove erroneous assert
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=2ccef01b8a85a4bfcd9a501c6625411abd042e11;p=thirdparty%2Ffreeradius-server.git

remove erroneous assert

now that we have duplicate detection, the assert is not needed
---

diff --git a/src/modules/proto_dhcpv4/proto_dhcpv4_udp.c b/src/modules/proto_dhcpv4/proto_dhcpv4_udp.c
index a0d8ddaed64..4cb8c2f3a42 100644
--- a/src/modules/proto_dhcpv4/proto_dhcpv4_udp.c
+++ b/src/modules/proto_dhcpv4/proto_dhcpv4_udp.c
@@ -229,8 +229,6 @@ static ssize_t mod_write(fr_listen_t *li, void *packet_ctx, UNUSED fr_time_t req
 
 	flags = UDP_FLAGS_CONNECTED * (thread->connection != NULL);
 
-	fr_assert(track->reply_len == 0);
-
 	/*
 	 *	Swap src/dst IP/port
 	 */
diff --git a/src/modules/proto_dhcpv6/proto_dhcpv6_udp.c b/src/modules/proto_dhcpv6/proto_dhcpv6_udp.c
index 1090c19daad..bf1eab84135 100644
--- a/src/modules/proto_dhcpv6/proto_dhcpv6_udp.c
+++ b/src/modules/proto_dhcpv6/proto_dhcpv6_udp.c
@@ -232,8 +232,6 @@ static ssize_t mod_write(fr_listen_t *li, void *packet_ctx, UNUSED fr_time_t req
 
 	flags = UDP_FLAGS_CONNECTED * (thread->connection != NULL);
 
-	fr_assert(track->reply_len == 0);
-
 	/*
 	 *	Send packets to the originator, EXCEPT that we always
 	 *	originate packets from our src_ipaddr.