From: James Jones <jejones3141@gmail.com>
Date: Sat, 9 Jul 2022 00:33:01 +0000 (-0500)
Subject: Check tmpl_find_vp() return value (CID #1503995) (#4600)
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=2cd9877bbc7c8cb7f4a0b437afdd8abdf73f69f5;p=thirdparty%2Ffreeradius-server.git

Check tmpl_find_vp() return value (CID #1503995) (#4600)

Now that tmpl_find_vp() returns -2 as advertised, we can check
the return value rather than checking vp, placating coverity.
---

diff --git a/src/modules/rlm_sometimes/rlm_sometimes.c b/src/modules/rlm_sometimes/rlm_sometimes.c
index 5287ade5b4b..3d6574f18aa 100644
--- a/src/modules/rlm_sometimes/rlm_sometimes.c
+++ b/src/modules/rlm_sometimes/rlm_sometimes.c
@@ -87,8 +87,7 @@ static unlang_action_t sometimes_return(rlm_rcode_t *p_result, module_ctx_t cons
 	/*
 	 *	Hash based on the given key.  Usually User-Name.
 	 */
-	tmpl_find_vp(&vp, request, inst->key);
-	if (!vp) RETURN_MODULE_NOOP;
+	if (tmpl_find_vp(&vp, request, inst->key) < 0) RETURN_MODULE_NOOP;
 
 	switch (vp->vp_type) {
 	case FR_TYPE_OCTETS: