From: Shivani Bhardwaj <shivanib134@gmail.com>
Date: Mon, 7 Oct 2019 10:38:18 +0000 (+0530)
Subject: Check data directory's permission while updating sources
X-Git-Tag: 1.2.0rc1~21
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=2cfe4fc6b7f09f896857ef7f5661c9fe190709b1;p=thirdparty%2Fsuricata-update.git

Check data directory's permission while updating sources

Closes redmine ticket #3219.
---

diff --git a/suricata/update/commands/updatesources.py b/suricata/update/commands/updatesources.py
index a47c24c..06a0d11 100644
--- a/suricata/update/commands/updatesources.py
+++ b/suricata/update/commands/updatesources.py
@@ -71,8 +71,12 @@ def compare_sources(initial_content, final_content):
 
 
 def write_and_compare(initial_content, fileobj):
-    with open(local_index_filename, "wb") as outobj:
-        outobj.write(fileobj.getvalue())
+    try:
+        with open(local_index_filename, "wb") as outobj:
+            outobj.write(fileobj.getvalue())
+    except IOError as ioe:
+        logger.error("Failed to open directory: %s", ioe)
+        return 1
     with open(local_index_filename, "rb") as stream:
         final_content = yaml.safe_load(stream)
     compare_sources(initial_content, final_content)