From: Jeff Lucovsky <jeff@lucovsky.org>
Date: Fri, 10 Jul 2020 12:16:06 +0000 (-0400)
Subject: detect: Correct Coverity REVERSE_INULL issue
X-Git-Tag: suricata-6.0.0-beta1~227
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=2d055ed1f7084a9f10a7122f5d485c51f9db81bc;p=thirdparty%2Fsuricata.git

detect: Correct Coverity REVERSE_INULL issue

This commit corrects the "Null pointer dereferences" issue (CID
1465221).
---

diff --git a/src/detect-engine.c b/src/detect-engine.c
index b984e587ca..a5f0d9225b 100644
--- a/src/detect-engine.c
+++ b/src/detect-engine.c
@@ -767,6 +767,10 @@ static void DetectBufferTypeFreeFunc(void *data)
 {
     DetectBufferType *map = (DetectBufferType *)data;
 
+    if (map == NULL) {
+        return;
+    }
+
     /* Release transformation option memory, if any */
     for (int i = 0; i < map->transforms.cnt; i++) {
         if (map->transforms.transforms[i].options == NULL)
@@ -779,9 +783,8 @@ static void DetectBufferTypeFreeFunc(void *data)
         }
         sigmatch_table[map->transforms.transforms[i].transform].Free(NULL, map->transforms.transforms[i].options);
     }
-    if (map != NULL) {
-        SCFree(map);
-    }
+
+    SCFree(map);
 }
 
 static int DetectBufferTypeInit(void)