From: James Jones <jejones3141@gmail.com>
Date: Fri, 23 Sep 2022 11:45:17 +0000 (-0500)
Subject: Check fr_unlink() return in radsniff (CID #1504435&) (#4740)
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=2d150d514d0c9d9079c4614e8374056a20bddaf4;p=thirdparty%2Ffreeradius-server.git

Check fr_unlink() return in radsniff (CID #1504435&) (#4740)
---

diff --git a/src/bin/radsniff.c b/src/bin/radsniff.c
index 201c9ef5e58..61cf6d1cd44 100644
--- a/src/bin/radsniff.c
+++ b/src/bin/radsniff.c
@@ -494,7 +494,7 @@ static void rs_packet_save_in_output_dir(uint64_t count, UNUSED rs_status_t stat
 	}
 
 	/* ensure to remove existing file */
-	fr_unlink(filename);
+	if (fr_unlink(filename) < 0) usage(64);
 
 	if (fr_log_init_file(&output_file, filename) < 0) {
 		ERROR("Failed opening %s output file.", filename);