From: Florian Krohm <florian@eich-krohm.de>
Date: Sat, 20 Oct 2012 19:52:14 +0000 (+0000)
Subject: Add a FIXME
X-Git-Tag: svn/VALGRIND_3_9_0~604
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=2d248fcd2ebee0b6a41c2be43945823f6a6eeb6e;p=thirdparty%2Fvalgrind.git

Add a FIXME


git-svn-id: svn://svn.valgrind.org/valgrind/trunk@13064
---

diff --git a/coregrind/m_options.c b/coregrind/m_options.c
index a1de249180..2a3ea3ded2 100644
--- a/coregrind/m_options.c
+++ b/coregrind/m_options.c
@@ -211,6 +211,8 @@ Char* VG_(expand_file_name)(Char* option_name, Char* format)
                   } else if ('}' == format[i]) {
                      // Temporarily replace the '}' with NUL to extract var
                      // name.
+                     // FIXME: this is not safe as FORMAT is sometimes a
+                     // string literal which may reside in read-only memory
                      format[i] = 0;
                      qual = VG_(getenv)(qualname);
                      if (NULL == qual) {