From: Nick Porter <nick@portercomputing.co.uk>
Date: Thu, 13 Jul 2023 08:48:26 +0000 (+0100)
Subject: If parsing attributes fails, discard temporary list
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=2d292e591ed9f9d990d50c632fbefbf9632e9593;p=thirdparty%2Ffreeradius-server.git

If parsing attributes fails, discard temporary list
---

diff --git a/src/lib/util/pair_legacy.c b/src/lib/util/pair_legacy.c
index 04b025ee91a..259228a5aea 100644
--- a/src/lib/util/pair_legacy.c
+++ b/src/lib/util/pair_legacy.c
@@ -398,7 +398,10 @@ fr_token_t fr_pair_list_afrom_str(TALLOC_CTX *ctx, fr_dict_attr_t const *parent,
 
 	fr_pair_list_init(&tmp_list);
 
-	if (fr_pair_list_afrom_substr(ctx, parent, NULL, buffer, buffer + len, &tmp_list, &token, 0, &relative_vp, false) < 0) return T_INVALID;
+	if (fr_pair_list_afrom_substr(ctx, parent, NULL, buffer, buffer + len, &tmp_list, &token, 0, &relative_vp, false) < 0) {
+		fr_pair_list_free(&tmp_list);
+		return T_INVALID;
+	}
 
 	fr_pair_list_append(list, &tmp_list);