From: Mariusz Dabrowski Date: Wed, 12 Oct 2016 12:28:42 +0000 (+0200) Subject: imsm: block chunk size change for RAID 10 X-Git-Tag: mdadm-4.0~47 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=2d2b0eb7b9d5603edb2e41e2c2860042fbbe8c92;p=thirdparty%2Fmdadm.git imsm: block chunk size change for RAID 10 Chunk size change of RAID 10 array fails because it is not supported but invalid values still are being written to metadata and array cannot be assembled after stop. Operation should be blocked before metadata update. Signed-off-by: Mariusz Dabrowski Signed-off-by: Jes Sorensen --- diff --git a/super-intel.c b/super-intel.c index e1124ba5..5cd320ed 100644 --- a/super-intel.c +++ b/super-intel.c @@ -10087,10 +10087,16 @@ enum imsm_reshape_type imsm_analyze_change(struct supertype *st, } if ((geo->chunksize > 0) && (geo->chunksize != UnSet) - && (geo->chunksize != info.array.chunk_size)) + && (geo->chunksize != info.array.chunk_size)) { + if (info.array.level == 10) { + pr_err("Error. Chunk size change for RAID 10 is not supported.\n"); + change = -1; + goto analyse_change_exit; + } change = CH_MIGRATION; - else + } else { geo->chunksize = info.array.chunk_size; + } chunk = geo->chunksize / 1024;