From: Eric Blake <eblake@redhat.com>
Date: Tue, 4 Oct 2011 16:24:40 +0000 (-0600)
Subject: build: fix 'make distcheck' with pdwtags installed
X-Git-Tag: v0.9.7-rc1~183
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=2d45ae5a013a0353688d92c3e93b7e53a2939a96;p=thirdparty%2Flibvirt.git

build: fix 'make distcheck' with pdwtags installed

I am getting this failure with 'make distcheck':

  GEN    ../../src/remote_protocol-structs
/bin/sh: ../../src/remote_protocol-structs-t: Permission denied
make[4]: *** [../../src/remote_protocol-structs] Error 1

since it attempts a sub-run of a VPATH 'make check' where $(srcdir)
is intentionally read-only.  I'm not sure which commit introduced
the problem, although I suspect it was around 62dee6f when I
refactored protocol struct checking to be more powerful.

$(@F) is required by POSIX, and although it is not yet portable
to all make implementations, we already require GNU make.

* src/Makefile.am (PDWTAGS): Generate temp file into current
directory, since $(srcdir) is read-only during distcheck.
---

diff --git a/src/Makefile.am b/src/Makefile.am
index 738ee91237..9650139732 100644
--- a/src/Makefile.am
+++ b/src/Makefile.am
@@ -255,9 +255,9 @@ PDWTAGS = \
 		-e '    exit 8;'					\
 		-e '  }'						\
 		-e '}'							\
-		> $@-t;							\
+		> $(@F)-t;						\
 	  case $$? in 8) exit 0;; 0) ;; *) exit 1;; esac;		\
-	  diff -u $@-t $@; st=$$?; rm -f $@-t; exit $$st;	\
+	  diff -u $(@F)-t $@; st=$$?; rm -f $(@F)-t; exit $$st;		\
 	else								\
 	  echo 'WARNING: you lack pdwtags; skipping the $@ test' >&2;	\
 	  echo 'WARNING: install the dwarves package to get pdwtags' >&2; \