From: Michael Tremer <michael.tremer@ipfire.org>
Date: Fri, 2 Jul 2021 15:22:31 +0000 (+0000)
Subject: compress: Fix potential leak of cookie
X-Git-Tag: 0.9.28~1131
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=2d4af7593713ba16903491c60cc2b850856dac33;p=pakfire.git

compress: Fix potential leak of cookie

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>
---

diff --git a/src/libpakfire/compress.c b/src/libpakfire/compress.c
index 89275e2ae..91c81d779 100644
--- a/src/libpakfire/compress.c
+++ b/src/libpakfire/compress.c
@@ -287,14 +287,17 @@ FILE* pakfire_xzfopen(FILE* f, const char* mode) {
 
 		default:
 			errno = ENOTSUP;
-			free(cookie);
-			return NULL;
+			goto ERROR;
 	}
 
 	if (ret != LZMA_OK)
-		return NULL;
+		goto ERROR;
 
 	return fopencookie(cookie, mode, xz_functions);
+
+ERROR:
+	free(cookie);
+	return NULL;
 }
 
 // ZSTD