From: Volker Lendecke <vl@samba.org>
Date: Wed, 13 Aug 2025 13:27:39 +0000 (+0200)
Subject: smbd: Avoid an "else"
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=2d6899c03d9d72caaacb790bc776510f860f255a;p=thirdparty%2Fsamba.git

smbd: Avoid an "else"

We return in the if-branch

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
---

diff --git a/source3/smbd/smb2_process.c b/source3/smbd/smb2_process.c
index bd0e4644614..c7fe20dd928 100644
--- a/source3/smbd/smb2_process.c
+++ b/source3/smbd/smb2_process.c
@@ -938,8 +938,9 @@ static void smbd_smb2_server_connection_read_handler(
 		xconn->client->sconn->trans_num++;
 		xconn->client->sconn->num_requests++;
 		return;
+	}
 
-	} else if (!smbd_is_smb2_header(buffer, bufferlen)) {
+	if (!smbd_is_smb2_header(buffer, bufferlen)) {
 		exit_server_cleanly("Invalid initial SMB2 packet");
 		return;
 	}