From: Alan T. DeKok <aland@freeradius.org>
Date: Tue, 19 Feb 2013 01:56:47 +0000 (-0500)
Subject: Accessing a list global to the module means it's thread un-safe
X-Git-Tag: release_2_2_1~144
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=2d8438e1a90ad3102071a1389e6df1e17d0010ac;p=thirdparty%2Ffreeradius-server.git

Accessing a list global to the module means it's thread un-safe

The list should probably be changed to an RBtree for speed.
---

diff --git a/src/modules/rlm_radutmp/rlm_radutmp.c b/src/modules/rlm_radutmp/rlm_radutmp.c
index 8fae770be03..27739b03c14 100644
--- a/src/modules/rlm_radutmp/rlm_radutmp.c
+++ b/src/modules/rlm_radutmp/rlm_radutmp.c
@@ -731,7 +731,7 @@ static int radutmp_checksimul(void *instance, REQUEST *request)
 module_t rlm_radutmp = {
 	RLM_MODULE_INIT,
 	"radutmp",
-	RLM_TYPE_CHECK_CONFIG_SAFE | RLM_TYPE_HUP_SAFE,   	/* type */
+	RLM_TYPE_THREAD_UNSAFE | RLM_TYPE_CHECK_CONFIG_SAFE | RLM_TYPE_HUP_SAFE,   	/* type */
 	radutmp_instantiate,          /* instantiation */
 	radutmp_detach,               /* detach */
 	{