From: Michael Schroeder Date: Tue, 24 Jul 2018 11:37:47 +0000 (+0200) Subject: Also use unsigned int when bounds checking pool_arch2color() X-Git-Tag: 0.6.35~4 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=2d8b2509c79563ccb52dd478bd2dd29d6c2dce7a;p=thirdparty%2Flibsolv.git Also use unsigned int when bounds checking pool_arch2color() This is done so that the code doesn't crash when you pass a rel id. --- diff --git a/src/poolarch.h b/src/poolarch.h index 941f420a..13d236d3 100644 --- a/src/poolarch.h +++ b/src/poolarch.h @@ -24,7 +24,7 @@ extern unsigned char pool_arch2color_slow(Pool *pool, Id arch); static inline unsigned char pool_arch2color(Pool *pool, Id arch) { - if (arch >= pool->lastarch) + if ((unsigned int)arch >= (unsigned int)pool->lastarch) return ARCHCOLOR_ALL; if (pool->id2color && pool->id2color[arch]) return pool->id2color[arch];