From: Vladimir Oltean Date: Tue, 25 Nov 2025 11:48:36 +0000 (+0200) Subject: phy: lynx-28g: avoid memsetting lane already allocated with kzalloc() X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=2da0b2214f511744a967d370447bb9d511bf1348;p=thirdparty%2Flinux.git phy: lynx-28g: avoid memsetting lane already allocated with kzalloc() "priv" is allocated by lynx_28g_probe() using devm_kzalloc(), and the lane is memory inside that structure (&priv->lane[id]). We don't have to zero-initialize it, it is already filled with zeroes. Suggested-by: Vinod Koul Link: https://lore.kernel.org/linux-phy/aRYMM3ZuyBYH8zEC@vaman/ Signed-off-by: Vladimir Oltean Link: https://patch.msgid.link/20251125114847.804961-5-vladimir.oltean@nxp.com Signed-off-by: Vinod Koul --- diff --git a/drivers/phy/freescale/phy-fsl-lynx-28g.c b/drivers/phy/freescale/phy-fsl-lynx-28g.c index 61a992ff274f..f6e6ea1262bc 100644 --- a/drivers/phy/freescale/phy-fsl-lynx-28g.c +++ b/drivers/phy/freescale/phy-fsl-lynx-28g.c @@ -592,8 +592,6 @@ static int lynx_28g_probe_lane(struct lynx_28g_priv *priv, int id, struct lynx_28g_lane *lane = &priv->lane[id]; struct phy *phy; - memset(lane, 0, sizeof(*lane)); - phy = devm_phy_create(priv->dev, dn, &lynx_28g_ops); if (IS_ERR(phy)) return PTR_ERR(phy);