From: Aditya Garg Date: Fri, 20 Jun 2025 06:40:31 +0000 (+0530) Subject: imap-send: display port alongwith host when git credential is invoked X-Git-Tag: v2.51.0-rc0~99^2~2 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=2dacd35731d9d9947913eac991599ff000468cf3;p=thirdparty%2Fgit.git imap-send: display port alongwith host when git credential is invoked When requesting for passsword, git credential helper used to display only the host name. For example: Password for 'imaps://gargaditya08%40live.com@outlook.office365.com': Now, it will display the port along with the host name: Password for 'imaps://gargaditya08%40live.com@outlook.office365.com:993': This has been done to make credential helpers more specific for ports. Also, this behaviour will also mimic git send-email, which displays the port along with the host name when requesting for a password. Signed-off-by: Aditya Garg Signed-off-by: Junio C Hamano --- diff --git a/imap-send.c b/imap-send.c index c88d842819..1894a18f90 100644 --- a/imap-send.c +++ b/imap-send.c @@ -1082,7 +1082,7 @@ static void server_fill_credential(struct imap_server_conf *srvc, struct credent return; cred->protocol = xstrdup(srvc->use_ssl ? "imaps" : "imap"); - cred->host = xstrdup(srvc->host); + cred->host = xstrfmt("%s:%d", srvc->host, srvc->port); cred->username = xstrdup_or_null(srvc->user); cred->password = xstrdup_or_null(srvc->pass);